Add choose function and hypergeometric_likelihood

fau-klue / pandas-association-measures

Statistical association measures for Python pandas

MIT License

8 stars 2 forks source link

Add choose function and hypergeometric_likelihood #6

Closed martialblog closed 5 years ago

martialblog commented 5 years ago

Adds cython choose function
Adds hypergeometric_likelihood function
Fixes coverage report

ausgerechnet commented 5 years ago

sieht sinnvoll aus. was passiret mit cdef int N = min(k, n - k) + 1 wenn n<k?

martialblog commented 5 years ago

@ausgerechnet Gute Frage... muss man testen.

martialblog commented 5 years ago

@ausgerechnet Also aktuell ists so:

    assert bi.choose(5, 2) == 10
    assert bi.choose(2, 2) == 1
    assert bi.choose(0, 0) == 1
    assert bi.choose(-2, -2) == 1
    assert bi.choose(10, -2) == 1

Was nicht ganz analog zur R Funktion ist. In R wäre

    choose(-2, -2) == 0

Was denkst du?

martialblog commented 5 years ago

Habs jetzt analog zur R Funktion geschrieben