search

faucamp / python-gsmmodem

Python module to control a GSM modem attached to the system: send/receive SMS messages, handle calls, etc
GNU Lesser General Public License v3.0
388 stars 307 forks source link

Update serial_comms.py #69

Open havefunworkhard opened 8 years ago

havefunworkhard commented 8 years ago

Seems like self.serial.read(1) in serial_comms.py returns bytes in Python 3.x. But code expects strings and compares returned value with strings like RX_EOL_SEQ = '\r\n' or ''. The comparison result will always be False. In this case SerialComms will never _handleLineRead and TimeoutException will be raised.

alejandroMA commented 8 years ago

I been waiting 3 moths for a pull request to be merge or rejected :(

babca commented 8 years ago

@foXes68 Let's make the project alive again. I've merged all the fixes including yours here: https://github.com/babca/python-gsmmodem

please check it out and do a pull request there if you found any bugs.