Closed noursaidi closed 3 years ago
Merging #869 (a570a60) into master (69e7263) will decrease coverage by
0.11%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #869 +/- ##
==========================================
- Coverage 81.49% 81.38% -0.12%
==========================================
Files 42 42
Lines 5372 5372
==========================================
- Hits 4378 4372 -6
- Misses 994 1000 +6
Flag | Coverage Δ | |
---|---|---|
ata | 62.82% <ø> (ø) |
|
aux | 68.46% <ø> (-0.02%) |
:arrow_down: |
base | 66.31% <ø> (ø) |
|
dhcp | 67.66% <ø> (+0.01%) |
:arrow_up: |
many | 67.59% <ø> (ø) |
|
mud | 72.64% <ø> (-0.10%) |
:arrow_down: |
switch | 66.66% <ø> (-0.02%) |
:arrow_down: |
topo | 66.66% <ø> (-0.02%) |
:arrow_down: |
unit | 30.39% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
daq/traffic_analyzer.py | 86.50% <0.00%> (-3.18%) |
:arrow_down: |
daq/acl_state_collector.py | 82.19% <0.00%> (-1.37%) |
:arrow_down: |
daq/runner.py | 84.79% <0.00%> (-0.12%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 69e7263...a570a60. Read the comment docs.
The MUD test failure has been fixed in another PR, so might try rebasing this and see if it does better!
Thanks, recommitted and passes the tests now
This PR reverts PR #854 and resolves the underlying issue.
The problem was JDK11.0.11 update disabled TLS1 by default (https://www.oracle.com/java/technologies/javase/11-0-11-relnotes.html) This PR includes a script
subset/security/enable_tls1.sh
to update the configuration at container build. The TLS test container uses Ubuntu 20.04 and a newer version of OpenSSL which also default disables older/insecure protocols, so TLSv1 has also been enabled in OpenSSL.This bug meant the test always skipped, regardless of whether the DUT was running TLSv1 and the result should have been a pass/fail. The faux device currently run an older version, so is okay for now.