Change settle_sec to 0

[grafnu]

One thing necessary for testing at scale. Doesn't seem to break anything.

[grafnu]

Not now -- this is just the default configuration but we might want to turn it on for some specific install.

On Thu, Jun 10, 2021 at 10:04 AM pbatta @.***> wrote:

@.**** commented on this pull request.

In config/system/default.yaml https://github.com/faucetsdn/daq/pull/876#discussion_r649370124:

@@ -12,9 +12,6 @@ switch_setup: of_dpid: 2 uplink_port: 7

-# Time to let the network settle after some operations. -settle_sec: 5

Also remove other references? (proto/system_config.proto, daq/network.py etc?)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/faucetsdn/daq/pull/876#pullrequestreview-681040881, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIEPDYC3NZAGVDOQ4XYSE3TSDWCRANCNFSM46O46BHA .

[codecov[bot]]

Codecov Report

Merging #876 (2e77f54) into master (69e7263) will increase coverage by 0.05%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #876      +/-   ##
==========================================
+ Coverage   81.49%   81.54%   +0.05%     
==========================================
  Files          42       42              
  Lines        5372     5365       -7     
==========================================
- Hits         4378     4375       -3     
+ Misses        994      990       -4     

Flag	Coverage Δ
ata	63.01% <100.00%> (+0.19%)	:arrow_up:
aux	68.59% <100.00%> (+0.11%)	:arrow_up:
base	66.50% <100.00%> (+0.18%)	:arrow_up:
dhcp	67.83% <100.00%> (+0.18%)	:arrow_up:
many	67.92% <100.00%> (+0.33%)	:arrow_up:
mud	72.78% <100.00%> (+0.03%)	:arrow_up:
switch	66.80% <100.00%> (+0.12%)	:arrow_up:
topo	66.82% <100.00%> (+0.14%)	:arrow_up:
unit	30.27% <0.00%> (-0.13%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
daq/network.py	87.65% <100.00%> (-0.86%)	:arrow_down:
daq/traffic_analyzer.py	86.50% <0.00%> (-3.18%)	:arrow_down:
daq/acl_state_collector.py	82.19% <0.00%> (-1.37%)	:arrow_down:
daq/runner.py	84.14% <0.00%> (-0.77%)	:arrow_down:
daq/host.py	91.54% <0.00%> (+0.44%)	:arrow_up:
daq/faucet_event_client.py	82.84% <0.00%> (+1.18%)	:arrow_up:
daq/session_server.py	87.70% <0.00%> (+9.30%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 69e7263...2e77f54. Read the comment docs.