Host trigger queue for limiting simultaneous execution runs

[codecov[bot]]

Codecov Report

Merging #880 (98f49ab) into master (69e7263) will increase coverage by 0.06%. The diff coverage is 78.37%.

@@            Coverage Diff             @@
##           master     #880      +/-   ##
==========================================
+ Coverage   81.49%   81.56%   +0.06%     
==========================================
  Files          42       42              
  Lines        5372     5381       +9     
==========================================
+ Hits         4378     4389      +11     
+ Misses        994      992       -2     

Flag	Coverage Δ
ata	62.97% <62.16%> (+0.15%)	:arrow_up:
aux	68.57% <64.86%> (+0.09%)	:arrow_up:
base	66.48% <62.16%> (+0.17%)	:arrow_up:
dhcp	67.81% <64.86%> (+0.16%)	:arrow_up:
many	67.68% <64.86%> (+0.09%)	:arrow_up:
mud	72.75% <62.16%> (+<0.01%)	:arrow_up:
switch	66.73% <62.16%> (+0.05%)	:arrow_up:
topo	66.79% <62.16%> (+0.11%)	:arrow_up:
unit	30.77% <48.64%> (+0.37%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
daq/proto/system_config_pb2.py	100.00% <ø> (ø)
daq/runner.py	84.20% <78.37%> (-0.71%)	:arrow_down:
daq/traffic_analyzer.py	86.50% <0.00%> (-3.18%)	:arrow_down:
daq/acl_state_collector.py	82.19% <0.00%> (-1.37%)	:arrow_down:
daq/network.py	87.65% <0.00%> (-0.86%)	:arrow_down:
daq/host.py	91.54% <0.00%> (+0.44%)	:arrow_up:
daq/faucet_event_client.py	82.84% <0.00%> (+1.18%)	:arrow_up:
daq/session_server.py	87.70% <0.00%> (+9.30%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 69e7263...98f49ab. Read the comment docs.

[grafnu]

Unit test added. PTAL.

On Fri, Jun 11, 2021 at 5:41 PM henry54809 @.***> wrote:

@.**** commented on this pull request.

In daq/runner.py https://github.com/faucetsdn/daq/pull/880#discussion_r650321920:

• def _target_set_trigger(self, device, remote_trigger=False):

• if not self._target_set_check_state(device, remote_trigger):

• return False

• device.wait_remote = False

• LOGGER.info('TAPTAP queue device %s', device)

• device.queued = True

• self._target_set_queue.put(device)

• if self._target_triggered_maxed(additional=self._target_set_queue.qsize()):

• LOGGER.info('Target device %s triggering queued (%s)',

• device, self._target_set_queue.qsize())

• def _target_triggered_maxed(self, additional=0):

I think have different definitions of “full” is a source of confusion. Also I think all these changes can be easily unit tested.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/faucetsdn/daq/pull/880#discussion_r650321920, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIEPD5RCHBEFZZRCZZB6RTTSKUKBANCNFSM46RG27KQ .