Basic report framework

[codecov[bot]]

Codecov Report

Merging #893 (d61a3f0) into master (b3b1298) will increase coverage by 0.00%. The diff coverage is 95.23%.

@@           Coverage Diff           @@
##           master     #893   +/-   ##
=======================================
  Coverage   81.94%   81.94%           
=======================================
  Files          42       44    +2     
  Lines        5439     5479   +40     
=======================================
+ Hits         4457     4490   +33     
- Misses        982      989    +7     

Flag	Coverage Δ
ata	62.66% <95.23%> (+0.24%)	:arrow_up:
aux	68.18% <95.23%> (+0.16%)	:arrow_up:
base	66.15% <95.23%> (+0.23%)	:arrow_up:
dhcp	67.43% <95.23%> (+0.18%)	:arrow_up:
many	67.30% <95.23%> (-0.12%)	:arrow_down:
mud	72.37% <95.23%> (+0.09%)	:arrow_up:
switch	67.41% <95.23%> (+0.20%)	:arrow_up:
topo	66.43% <95.23%> (+0.19%)	:arrow_up:
unit	31.00% <83.33%> (+0.39%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
daq/proto/report_pb2_grpc.py	0.00% <0.00%> (ø)
daq/host.py	91.13% <100.00%> (ø)
daq/proto/report_pb2.py	100.00% <100.00%> (ø)
daq/report.py	98.38% <100.00%> (+0.01%)	:arrow_up:
daq/runner.py	84.51% <100.00%> (-0.03%)	:arrow_down:
daq/varz_state_collector.py	46.98% <0.00%> (-3.62%)	:arrow_down:
daq/acl_state_collector.py	82.19% <0.00%> (-1.37%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b3b1298...d61a3f0. Read the comment docs.

[grafnu]

It will be consumed by some client, even if it's not gRPC (protobuf isn't only useful for grpc). I want something that is well-structured and cross-language, so something more than an arbitrary dict (unstructured), and not just a dataclass (python-only).

On Tue, Jul 13, 2021 at 9:35 PM henry54809 @.***> wrote:

@.**** commented on this pull request.

In daq/runner.py https://github.com/faucetsdn/daq/pull/893#discussion_r669273297:

@@ -1075,6 +1078,13 @@ def _send_device_result(self, device, test_results): except Exception as e: LOGGER.error("Failed to send device results for device %s: %s ", device, e)

• def report_sink(self, report_dict):

If it's not consumed by some grpc client, does it really have to be in the protobuf? The existing dict / a dataclass to replace https://github.com/faucetsdn/daq/blob/master/daq/report.py#L240 should suffice.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/faucetsdn/daq/pull/893#pullrequestreview-705843863, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIEPD5ST7EQNX2LFBK277DTXUHXPANCNFSM5AKNLNBA .

[grafnu]

Any additional comments?