faucetsdn / daq

DEPRECATED -- DAQ (Device Automated Qualification) framework in no longer in use, supported, or maintained. It is here for archival purposes only.
Apache License 2.0
40 stars 32 forks source link

Fix flaky DNS test #914

Closed grafnu closed 3 years ago

grafnu commented 3 years ago

Was not ready for review yet...

On Thu, Aug 26, 2021 at 1:57 PM henry54809 @.***> wrote:

@.**** commented on this pull request.

In docker/include/bin/start_faux https://github.com/faucetsdn/daq/pull/914#discussion_r696972956:

@@ -287,6 +287,14 @@ if [ -n "${options[curl]}" ]; then (while true; do curl -o - http://google.com 2> /dev/null 1>&2; sleep 5; done) & fi

+# Do random DNS queries to make sure DNS is exercised w/o caching. +(

  • while true; do
  • nslookup $RANDOM.com

is it supposed to be commented out? And nslookup needs to be installed first on the faux containers.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/faucetsdn/daq/pull/914#pullrequestreview-739929950, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIEPD55B63626ZS2WSEE4TT62TERANCNFSM5C4EV4KQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

codecov[bot] commented 3 years ago

Codecov Report

Merging #914 (363ab07) into master (7e407fe) will decrease coverage by 0.07%. The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #914      +/-   ##
==========================================
- Coverage   82.16%   82.08%   -0.08%     
==========================================
  Files          45       45              
  Lines        5634     5637       +3     
==========================================
- Hits         4629     4627       -2     
- Misses       1005     1010       +5     
Flag Coverage Δ
ata 62.35% <85.71%> (+<0.01%) :arrow_up:
aux 67.58% <57.14%> (-0.06%) :arrow_down:
base 65.58% <57.14%> (-0.02%) :arrow_down:
dhcp 66.86% <57.14%> (-0.02%) :arrow_down:
many 67.01% <57.14%> (+0.21%) :arrow_up:
mud 71.60% <57.14%> (-0.06%) :arrow_down:
switch 67.01% <71.42%> (-0.01%) :arrow_down:
topo 65.85% <57.14%> (+<0.01%) :arrow_up:
unit 32.87% <28.57%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
daq/runner.py 84.64% <50.00%> (-0.26%) :arrow_down:
daq/host.py 91.14% <100.00%> (+0.01%) :arrow_up:
daq/network.py 93.40% <100.00%> (+0.09%) :arrow_up:
daq/varz_state_collector.py 46.98% <0.00%> (-3.62%) :arrow_down:
daq/topology.py 95.74% <0.00%> (-0.17%) :arrow_down:
daq/acl_state_collector.py 83.56% <0.00%> (+1.36%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7e407fe...363ab07. Read the comment docs.