search

faucetsdn / udmi

Universal Device Management Interface (UDMI) provides a high-level specification for the management and operation of physical IoT systems.
https://faucetsdn.github.io/udmi/
Apache License 2.0
49 stars 48 forks source link

Registrar - Does not delete devices in the registry which are not in the site model #378

Open noursaidi opened 2 years ago

noursaidi commented 2 years ago

When running registrar, if there are devices registered in the IoT core registry, which are not defined in the site model, they are not deleted from the registry.

Default behaviour should be to remove them, so the registry matches the site model

grafnu commented 2 years ago

Right now it blocks them rather than removing them. Deleting things is a fairly disruptive operation so not likely the right default behavior. But maybe creating a flag to say "delete them" would be appropriate...

On Tue, Jun 28, 2022 at 5:34 AM Noureddine @.***> wrote:

When running registrar, if there are devices registered in the IoT core registry, which are not defined in the site model, they are not deleted from the registry.

Default behaviour should be to remove them, so the registry matches the site model

— Reply to this email directly, view it on GitHub https://github.com/faucetsdn/udmi/issues/378, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIEPDZM3IG2N6EPXKSMRZDVRLBMDANCNFSM52BPRD2A . You are receiving this because you are subscribed to this thread.Message ID: @.***>

noursaidi commented 2 years ago

Right now it blocks them rather than removing them.

It's stopped doing that .. but I've just checked and seems to because it's become a configurable parameter. I've done a PR #382 to change the default.

But true about deletion, you're right. Default behaviour would be to block, and then a flag to delete devices if required (devices need to be unbound from respective gateways before they can be deleted). Maybe even a backup.. We have a use-case where a registry has with 20k of which about 5k are proxy devices aren't in the site model and were accidently created so need to be removed.

grafnu commented 2 years ago

Right -- I'd recommend a two phase approach to that... First being to block all devices that are candidates for deletion -- so we can test the system to make sure it's WAI, and then a separate pass to "delete all blocked devices" or something like that!

On Wed, Jun 29, 2022 at 10:03 AM Noureddine @.***> wrote:

Right now it blocks them rather than removing them.

It's stopped doing that .. but I've just checked and seems to because it's become a configurable parameter. I've done a PR #382 https://github.com/faucetsdn/udmi/pull/382 to change the default.

But true about deletion, you're right. Default behaviour would be to block, and then a flag to delete devices if required (devices need to be unbound from respective gateways before they can be deleted). Maybe even a backup.. We have a use-case where a registry has with 20k of which about 5k are proxy devices aren't in the site model and were accidently created so need to be removed.

— Reply to this email directly, view it on GitHub https://github.com/faucetsdn/udmi/issues/378#issuecomment-1170022563, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIEPD56ZGN2II5HHK6FT4TVRRJTNANCNFSM52BPRD2A . You are receiving this because you commented.Message ID: @.***>