search

fauna-labs / serverless-fauna

MIT No Attribution
18 stars 3 forks source link

Update dependencies #23

Closed macmv closed 2 years ago

macmv commented 2 years ago

This PR updates serverless to version 3. Serverless 2 has a bunch of security vulnerabilities, so it makes sense to update to the latest version of serverless.

Serverless 3 has some breaking changes, outlined here. The only one that might affect us internally is that the config file can no longer be placed within a nested directory. Seeing as serverless 3 has a lot of breaking changes, this PR also bumps this plugin to version 0.2.0.

Serverless 3 doesn't break this plugin, and all tests are still passing after this update.

cleve-fauna commented 2 years ago

This is a fairly significant breaking change. If this is indeed the case, we should bump the version of serverless-fauna accordingly to make it obvious its breaking.

There are several other breaking changes mentioned here: https://www.serverless.com/framework/docs/guides/upgrading-v3

macmv commented 2 years ago

Given that we are on release 0.1.6, I'd say switching to 0.2.0 would be valid, although the docs suggest we should bump the major version. Thoughts?

I read through the list of breaking changes. Since we don't actually use AWS credentials to deploy to fauna, I don't think we will have any problems. If we use serverless-dotenv-plugin we'll have breakages. The fauna serverless plugin doesn't support any custom command line parameters, so that shouldn't be breaking.

I'm aware of serverless being used in the frontdoor service and backup/restore functions. I tested 3.0 locally, and everything worked. Are there any other use cases I should be aware of?

cleve-fauna commented 2 years ago

I'm aware of serverless being used in the frontdoor service and backup/restore functions. I tested 3.0 locally, and everything worked. Are there any other use cases I should be aware of?

This package is open-source. Any customer could be using it.