fauna / fauna-js

Javascript driver for Fauna v10 (current)
https://fauna.com
Other
37 stars 7 forks source link

Fix incorrect paths type on ConstraintFailure #275

Closed ecooper closed 4 months ago

ecooper commented 4 months ago

Ticket(s): FE-5552

Problem

The type ConstraintFailure["paths"] was set to be Array<number | string>. However, the wire response for paths is actually an array of arrays. Anyone trying to interact with paths using the declared types would have a runtime error. The existing integration tests only check paths is defined.

Solution

Fix the the types to match the current response, and update the integration tests to actually test the array of array data structure. The expect statements were updated to use more "complex" matchers to reduce the number of assertions while visually documenting the data structures.

Result

The types now match the expected wire result and the integration tests validate that structure more concretely.

Out of scope

N/A.

Testing

Updated the existing constraint failure query tests.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.