fauna / fauna-js

Javascript driver for Fauna v10 (current)
https://fauna.com
Other
37 stars 7 forks source link

`timeout_ms` is not a great name/hard to document #33

Closed breathe closed 1 year ago

breathe commented 1 year ago

https://github.com/fauna/fauna-js/blob/f88926faafa87e1bfec31e7ade7277cfb3013392/src/client-configuration.ts#L22

I get that this derives its name from the wire protocol - however we have to expose this to driver consumers as well, and when documenting this in the drivers, the name is not great. It will be easy to confuse this with other driver timeout properties -- query_timeout_ms would be a better name imo

cleve-fauna commented 1 year ago

good call

cleve-fauna commented 1 year ago

THis change is being made in both the wire protocol and the driver. PR shortly

ptpaterson commented 1 year ago

Resolved by #73