faune / homebridge-grohe-sense

Grohe Ondus Sense
Apache License 2.0
9 stars 4 forks source link

one of 7 sense devices with an error #8

Closed Flieger37 closed 3 years ago

Flieger37 commented 3 years ago

Thank you for programming the plugin!

I am getting the following error when starting homebridge for one of my seven sense devices (running connected to a an Ondus guard):

"[Ondus] [Bad OG] Unable to update device status: getURL(): Unexpected server response: Error: Too Many Requests"

May be its because of to many devices?

Regards Martin

faune commented 3 years ago

Yes, there seems to exist a server side cap on how many requests the api can handle within a certain time period. A debug log of this happening can help me better understand the issue perhaps?

Flieger37 commented 3 years ago

This error occurs once or twice in an hour:

[13/12/2020, 04:36:55] [Ondus] [Waschküche] Unable to update device status: getURL(): Unexpected server response: Error: Too Many Requests

[13/12/2020, 05:36:55] [Ondus] [Waschküche] Unable to update temperature and humidity: getURL(): Unexpected server response: Error: Too Many Requests [13/12/2020, 06:36:55] [Ondus] [Dachboden] Unable to update device status: getURL(): Unexpected server response: Error: Too Many Requests [13/12/2020, 07:36:55] [Ondus] [Waschküche] Unable to update device status: getURL(): Unexpected server response: Error: Too Many Requests [13/12/2020, 08:36:55] [Ondus] [Dachboden] Unable to update device status: getURL(): Unexpected server response: Error: Too Many Requests [13/12/2020, 08:36:55] [Ondus] [Waschküche] Unable to update temperature and humidity: getURL(): Unexpected server response: Error: Too Many Requests [13/12/2020, 09:36:55] [Ondus] [Waschküche] Unable to update device status: getURL(): Unexpected server response: Error: Too Many Requests [13/12/2020, 10:36:55] [Ondus] [Waschküche] Unable to update device status: getURL(): Unexpected server response: Error: Too Many Requests

Just let me know, what to do to provide more information to you.

Regards Martin

faune commented 3 years ago

Will try and add a backoff algorithm in the http handling for the next release

faune commented 3 years ago

Hi, is it possible for you to test from a feature branch? I have added throttling support to https://github.com/faune/homebridge-grohe-sense/tree/feature/release-1.5 but have no idea what rate limits the Ondus API uses, and this fix has a potential to slow down your home bridge instance if the limits are not configured correctly.

I want feedback on if this fixes your issue related to "Too Many Requests"

Flieger37 commented 3 years ago

Looks good, no more errors - Thank's:

[03/03/2021, 20:03:54] [Ondus] [Bad EG] No pending notifications

[03/03/2021, 20:03:54] [Ondus] [Bad OG] No pending notifications [03/03/2021, 20:03:54] [Ondus] [Dachboden] No pending notifications [03/03/2021, 20:03:54] [Ondus] [Bad DG] No pending notifications [03/03/2021, 20:03:54] [Ondus] [Küche] No pending notifications [03/03/2021, 20:03:54] [Ondus] [Guard Keller] No pending notifications [03/03/2021, 20:03:54] [Ondus] [Waschküche] No pending notifications [03/03/2021, 20:03:54] [Ondus] [Flur Keller] No pending notifications [03/03/2021, 20:03:54] [Ondus] [Guard Keller] Timestamp: 2021-03-03T20:02:08.000+01:00 [03/03/2021, 20:03:54] [Ondus] [Guard Keller] => Valve: Open [03/03/2021, 20:03:54] [Ondus] [Guard Keller] => Flowrate: 0 [03/03/2021, 20:03:54] [Ondus] [Guard Keller] => Pressure: 4.1 bar [03/03/2021, 20:03:54] [Ondus] [Guard Keller] => Temperature: 14.5˚C

faune commented 3 years ago

Very good! V1.5 will have a new config pane for setting throttling limits from the GUI, so I think I will use current values as default values since it worked for you. Thanks for the help!

faune commented 3 years ago

BTW are any of your 7 devices a Sense Plus, the type connected to main ac and not battery operated?

Flieger37 commented 3 years ago

I was glad to help and am happy about the good result.

All devices are sense with batteries (and one guard) - no sense Plus devices.