Closed max-k closed 3 years ago
Are there any pending feature/bugs that need to be addressed?
Hi,
Yes, at least the PR I made on the project to fix a bug regarding custom event loop usage.
We can make a fork of it. Should I add you as a maintainer @max-k ? That way you can create a fork of it and merge it
I'm not sure to have enough skills to maintain the whole thing but I can try to help, at least.
Hi, I made the fork and re-create my MR on it. I'm currently updating the README. Do you have a suggestion for the name of the python artifact ? (mode-fork ? mode-streaming ? faust-streaming-mode ?)
mode-streaming
? I will leave it to you :)
mode-streaming sounds not so bad. Let's go for it. Thank you very much.
@max-k Hey, thanks for your effort. I have created a pull request from two weeks ago faust-streaming/mode#6, but it's still in pending state. Could you take a look? Do you still pay time to keep maintaining mode
? I volunteer to be a maintainer of this fork. A lot of my applications are depending on mode
package. So, I have to and hope to keep bug fix even add more features to mode
. Of course, the compatibility to faust-streaming
is the first priority. @patkivikram
Hi @lqhuang , Thank you for your contribution. I'll take a look at it as soon as possible.
Hi,
Thank you for your work.
Do you plan to also fork mode ?
It is another project formerly maintained by a robinhood employee and today it looks abandoned.
It is an important dependency of Faust so it could be valuable to keep it updated in parallel of your Faust fork.
If there is anything I can do help you in this process, just ask.
Thank you very much.