faust-streaming / faust

Python Stream Processing. A Faust fork
https://faust-streaming.github.io/faust/
Other
1.65k stars 183 forks source link

Make compatible with new aiokafka #566

Closed AntonOfTheWoods closed 11 months ago

AntonOfTheWoods commented 1 year ago

Checklist

Steps to reproduce

Use aiokafka @ git+https://github.com/aio-libs/aiokafka.git@88c694546101e43c92d3a7349f02a9f74798766f as a dependency

Expected behavior

Work as normal

Actual behavior

Requires kafka-python, which is not explicitly declared as a requirement of faust - it is an assumed dependency of aiokafka, which will no longer be a dependency of aiokafka from the next release. kafka-python has been "abandoned" (according to aiokafka anyway). The dependencies

Full traceback

...
  File "/usr/local/lib/python3.12/site-packages/faust/transport/drivers/aiokafka.py", line 38, in <module>
    from kafka import TopicPartition
ModuleNotFoundError: No module named 'kafka'

Versions

See https://github.com/faust-streaming/faust/pull/565

AntonOfTheWoods commented 11 months ago

Fixed by https://github.com/faust-streaming/faust/pull/565