search

faust-streaming / mode

Python AsyncIO Services
https://faust-streaming.github.io/mode/
Other
43 stars 16 forks source link

Ensure future in sleep method #34

Closed wbarnha closed 1 year ago

wbarnha commented 1 year ago

Hopefully this will fix #33.

wbarnha commented 1 year ago

Tests pass for Python 3.10 on my machine. I need to fix the GitHub runners...

lqhuang commented 1 year ago

LGTM. Besides, may I suggest to add an unitttest for similar function calls?

lqhuang commented 1 year ago

It's a little wired why no result of CI was reported now.

wbarnha commented 1 year ago

LGTM. Besides, may I suggest to add an unitttest for similar function calls?

I agree, this is probably the right move. I've been lazy about adding unit tests when I claim to be fixing issues.

lqhuang commented 1 year ago

@wbarnha Could you check line 908 in the same file and update it like what you did yet.

lqhuang commented 1 year ago

I agree, this is probably the right move. I've been lazy about adding unit tests when I claim to be fixing issues.

I know, LOL 😂 At least, let's merge this PR.

lqhuang commented 1 year ago

Did you already see reported CI results? In my side, none of CI jobs has started and the merge button is in disable status.

wbarnha commented 1 year ago

Did you already see reported CI results? In my side, none of CI jobs has started and the merge button is in disable status.

Currently looking into it. We've had similar issues occur in the past with Faust, albeit rarely. It's similar to what's reported in https://github.com/orgs/community/discussions/26698.

wbarnha commented 1 year ago

Following the steps in https://stackoverflow.com/a/58190576/9852671 fixed the CI jobs.

lqhuang commented 1 year ago

@wbarnha Could you check line 908 in the same file and update it like what you did yet.

Seems you forget to update line 908

await asyncio.wait_for(
    self._shutdown.wait(),
    self.shutdown_timeout,
)
wbarnha commented 1 year ago

@wbarnha Could you check line 908 in the same file and update it like what you did yet.

Seems you forget to update line 908

await asyncio.wait_for(
    self._shutdown.wait(),
    self.shutdown_timeout,
)

Funny enough, I saw that exact section and when I tried changing things, the unit tests failed. I'll need to take another look at it.