search

faust-streaming / mode

Python AsyncIO Services
https://faust-streaming.github.io/mode/
Other
43 stars 16 forks source link

Bring back changes to services.py from 0.3.1 just fix import logic #37

Closed wbarnha closed 1 year ago

wbarnha commented 1 year ago

Let's properly test things with Faust from hereon to make sure there aren't issues like this again in the future.

The big mistake we made was changing the imports of

from .utils.contexts import AsyncExitStack, ExitStack
from .utils.locks import Event

to

from asyncio.locks import Event
from contextlib import AsyncExitStack, ExitStack

Hopefully we won't encounter #33 again.

wbarnha commented 1 year ago

Just tested it with Faust v0.10.0, it's safe for merging.

lqhuang commented 1 year ago

It's fine for me to temporarily rebase back (utils) to old codes to fix bugs, so I agree to merge it for now. But, IMHO, I still think we should adapt with std implementation, only except stdlib really do not provide the extra function we need.

How do you think about it?

I will try to use asyncio style Event later to let everything (of course including faust) works well if it is possible.

lqhuang commented 1 year ago

Feel free to @ me from faust, I will provide my opinions as I could. Thanks to @wbarnha, you have made a lot of work to let community become active 👍