search

faust-streaming / mode

Python AsyncIO Services
https://faust-streaming.github.io/mode/
Other
43 stars 16 forks source link

Revert sleep time to 1.1 from 2.0 #41

Closed wbarnha closed 1 year ago

wbarnha commented 1 year ago

Apparently there's a hardcoded value of 1.2 in https://github.com/faust-streaming/mode/blob/17c5d2996e4706baa37b18bd8fa03687409120ad/mode/timers.py#L13 so we may have made a terrible mistake.

lqhuang commented 1 year ago

Fine. It's my fault! So sorry 😭

lqhuang commented 1 year ago

Let's add more documentation for these hard codes / magic codes

wbarnha commented 1 year ago

Agreed! I also share responsibility for the mistake 😄

lqhuang commented 1 year ago

And does it cause some incorrect behaviors in Faust? Could you link issues or your finds here?