faust-streaming / mode

Python AsyncIO Services
https://faust-streaming.github.io/mode/
Other
42 stars 16 forks source link

docs(readme): add block code type #48

Closed manawasp closed 7 months ago

manawasp commented 7 months ago

Hello,

Just submitting this small MR to fix syntax highlight color on README

wbarnha commented 7 months ago

Looks like linting got updated. 🤦‍♂️ Probably the same issue as https://github.com/faust-streaming/faust/pull/609 from the looks of it.

manawasp commented 7 months ago

Looks like linting got updated. 🤦‍♂️ Probably the same issue as faust-streaming/faust#609 from the looks of it.

I just opened another to fix this, I will rebase after merged to master.

I would like to polish some internals here so, I would like to have your opinion:

wbarnha commented 7 months ago

I've typically preferred using pip-compile to freeze dependencies, but I can still be sold on using poetry if need-be. I should go back and re-read from documentation to see if my opinion can be changed. My main argument against it is that there are some cases where dependency management can be a pain when trying to support new Python versions or projects, however that happens so infrequently that it may be trivial.