Most changes are about type mismatch my_var: str = None => my_var: Optional[str] = None
Drop unused # noqa rules
Regrouped some requirements under the dev.txt
Some formatting note:
def __delitem__(self, i: int) -> None: ...
will be changed to
def __delitem__(self, i: int) -> None:
...
The first formatting version was introduced by black 2024 version (~ a month ago), ruff will support this soon. In my opinion just following the chosen tool available features, going backward then forward is fine.
I used ruff.toml for the configuration instead of the pyproject.toml, I prefer to provide a dedicated PR to regroup all configuration under the pyproject.toml.
I see the initial line-length setup is 79, black/ruff default line length is 88 I would tend to match this, but before applying this I would like to know your opinion.
Also I would tend to have less requirements files default.txt, test.txt, docs.txt:
dev.txt => test.txt (I believe which people setup development will also need the test environment)
ci.txt => test.txt (just containing pytest-cov)
dist.txt => test.txt & docs.txt, not totally sure if possible as I see wheel, twine & packaging inside.
Hey,
Following the proposal here this PR proposal switch linter and formatter to ruff:
Applied linter & formatter:
my_var: str = None
=>my_var: Optional[str] = None
# noqa
rulesdev.txt
Some formatting note:
will be changed to
The first formatting version was introduced by black 2024 version (~ a month ago), ruff will support this soon. In my opinion just following the chosen tool available features, going backward then forward is fine.
ruff.toml
for the configuration instead of thepyproject.toml
, I prefer to provide a dedicated PR to regroup all configuration under thepyproject.toml
.line-length
setup is79
, black/ruff default line length is88
I would tend to match this, but before applying this I would like to know your opinion.default.txt
,test.txt
,docs.txt
:dev.txt
=>test.txt
(I believe which people setup development will also need the test environment)ci.txt
=>test.txt
(just containingpytest-cov
)dist.txt
=>test.txt
&docs.txt
, not totally sure if possible as I seewheel
,twine
&packaging
inside.