search

faust-streaming / python-rocksdb

Python bindings for RocksDB used by faust-streaming
https://faust-streaming.github.io/python-rocksdb/
BSD 3-Clause "New" or "Revised" License
24 stars 5 forks source link

Change setup and workflows for this project #3

Closed wbarnha closed 2 years ago

wbarnha commented 2 years ago

I've decided to go ahead and activate the job that allows us to automatically upload builds to PyPi. We'll need to define PYPI_API_TOKEN in this repo's secrets, @patkivikram.

wbarnha commented 2 years ago

On second thought- do we want really want to release as v0.9.0 and not v0.8.1?

austinnichols101 commented 2 years ago

there has already been a 0.8.1 release (0.8.6 is the latest release).

wbarnha commented 2 years ago

there has already been a 0.8.1 release (0.8.6 is the latest release).

I'm a bit confused by this statement. I understand the latest release of faust-streaming is 0.8.6, whereas faust-streaming/python-rocksdb is v0.8.0

patkivikram commented 2 years ago

I've decided to go ahead and activate the job that allows us to automatically upload builds to PyPi. We'll need to define PYPI_API_TOKEN in this repo's secrets, @patkivikram.

Sure go ahead and do that. Do you need anything from my end? On a similar note could we do something similar for faust-streaming?

wbarnha commented 2 years ago

I've decided to go ahead and activate the job that allows us to automatically upload builds to PyPi. We'll need to define PYPI_API_TOKEN in this repo's secrets, @patkivikram.

Sure go ahead and do that. Do you need anything from my end? On a similar note could we do something similar for faust-streaming?

I don't have access to either repositories as a maintainer, so either I'll need authorization to add a token or you'll need to do it.

wbarnha commented 2 years ago

I'd also like to tag the initial release as v0.8.1rc1 or v0.9.0rc1 in case something goes awry.

wbarnha commented 2 years ago

Hold off on merging, there's a bug hidden in the upload job.

wbarnha commented 2 years ago

Fixed the build jobs, but I need to make sure that my own upload jobs run.

wbarnha commented 2 years ago

It builds usable wheel files now, but each wheel file is 66 MB... https://test.pypi.org/manage/project/faust-streaming-rocksdb/release/0.9.0rc2/

Meanwhile the sdist is 270 kB, and unusable. Yuck.

wbarnha commented 2 years ago

Never mind, the sdist is good to go! I was erronously using --no-deps when running pip install.