search

faustedition / faust-web

Web frontend for the edition of Goethe's Faust
http://faustedition.net/
3 stars 1 forks source link

Text view: page beginning at top of screen #587

Closed gerritbruening closed 3 years ago

gerritbruening commented 3 years ago

When I visit http://dev.faustedition.net/document?sigil=C.1_4&page=34&view=facsimile_text or other pages in the facsimile_text view the beginning of page 245 appears in the middle of the screen. I would expect it to appear right below the page header. Is this intended, has this always been like this?

gerritbruening commented 3 years ago

http://v1-0.faustedition.net/document?sigil=C.1_4&page=34&view=facsimile_text is different, page beginning is where I had expected it, i.e., at the top.

thvitt commented 3 years ago

'center' scrolling for fragments has been introduced by https://github.com/faustedition/faust-web/commit/24e30f4749a9088c4668378e4fa8bf7ac8115f4e , fixing multiple issues in 1.0, but we can adjust that for scrolling to a page.

Would you prefer the page mark topmost on the page:

image

or rather offset by, e.g., 24px so you can see the previous line:

image

gerritbruening commented 3 years ago

Thanks for these visualizations, I would prefer the page mark topmost on the page.