favadi / flycheck-gometalinter

Flycheck checker for gometalinter
BSD 2-Clause "Simplified" License
57 stars 8 forks source link

Should adding metalinter disable default checks flycheck runs? #14

Closed ddgenome closed 6 years ago

ddgenome commented 6 years ago

By default in Go mode, flycheck supports several checkers by default:

  1. go-gofmt
  2. go-golint
  3. go-vet
  4. go-build or go-test
  5. go-errcheck
  6. go-unconvert
  7. go-megacheck

see http://www.flycheck.org/en/latest/languages.html#go

Of these, gometalinter runs runs golint, go vet, errcheck, unconvert, and megacheck by default.

Should flycheck-gometalinter remove the duplicates from flycheck-checkers when it adds gometalinter? megacheck in particular is quite CPU intensive.

ddgenome commented 6 years ago

Adding something like this should do it:

(setq flycheck-checkers (remove 'go-gofmt (remove 'go-golint (remove 'go-vet (remove 'go-errcheck (remove 'go-megacheck (remove 'go-unconvert flycheck-checkers)))))))
favadi commented 6 years ago

@ddgenome I added flycheck-gometalinter to the begining of flycheck-checkers (https://github.com/favadi/flycheck-gometalinter/blob/c90ea1aba80ddfdf603c9ba731be302400fd6ba2/flycheck-gometalinter.el#L119) and as we don't define next-checkers, those builtin checkers should be disabled already.

favadi commented 6 years ago

Closing as it works as expected.