search

fave77 / Mathball

A JavaScript library for Competitive Programming
https://fave77.github.io/Mathball-Docs/
MIT License
99 stars 49 forks source link

Prime Number Enhanced #101

Closed baibhabmondal closed 5 years ago

baibhabmondal commented 5 years ago

Do the checklist before submitting the PR:

Q: What version of Node.js you've used in the project? (e.g. Node v10.11.0) A: v10.14.0

Q: Mention the Issue Number! (e.g. Fixed #8) A: fixed #97

codecov-io commented 5 years ago

Codecov Report

Merging #101 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #101   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          56     56           
  Lines         694    702    +8     
=====================================
+ Hits          694    702    +8
Impacted Files Coverage Δ
src/prime/index.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7360f40...47c9f42. Read the comment docs.

baibhabmondal commented 5 years ago

What files do I need to include?

fave77 commented 5 years ago

@baibhabmondal please read the contribution guidelines again

baibhabmondal commented 5 years ago

I read the guidelines, I am not getting which files to include. I have overwritten the isPrime function, therefore, the readme.md is already contains isPrime. I am assuming that you're telling me to update Readme.md.