Closed sweezy793 closed 5 years ago
Merging #119 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #119 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 65 66 +1
Lines 879 895 +16
=====================================
+ Hits 879 895 +16
Impacted Files | Coverage Δ | |
---|---|---|
src/index.js | 100% <100%> (ø) |
:arrow_up: |
src/primefactor/index.js | 100% <100%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update edbf9ea...426dce0. Read the comment docs.
@sweezy793 The PR looks good but in issue #113 it is specifically mentioned that function would be
M.findPrimeFactors()
and notM.primefactor()
. So, make the required changes!
Done!
Do the checklist before submitting the PR:
Q: What version of Node.js you've used in the project? (
e.g. Node v10.11.0
) A:v10.15.1Q: Mention the Issue Number! (
e.g. Fixed #8
) A:Fixed #113Give additional information regarding the PR below: This function gives all the prime factors in form of array of a number which would be given as an argument.