fave77 / Mathball

A JavaScript library for Competitive Programming
https://fave77.github.io/Mathball-Docs/
MIT License
99 stars 49 forks source link

Prime factorization #119

Closed sweezy793 closed 5 years ago

sweezy793 commented 5 years ago

Do the checklist before submitting the PR:

Q: What version of Node.js you've used in the project? (e.g. Node v10.11.0) A:v10.15.1

Q: Mention the Issue Number! (e.g. Fixed #8) A:Fixed #113

codecov-io commented 5 years ago

Codecov Report

Merging #119 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #119   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          65     66    +1     
  Lines         879    895   +16     
=====================================
+ Hits          879    895   +16
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) :arrow_up:
src/primefactor/index.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update edbf9ea...426dce0. Read the comment docs.

sweezy793 commented 5 years ago

@sweezy793 The PR looks good but in issue #113 it is specifically mentioned that function would be M.findPrimeFactors() and not M.primefactor(). So, make the required changes!

Done!