fave77 / Mathball

A JavaScript library for Competitive Programming
https://fave77.github.io/Mathball-Docs/
MIT License
99 stars 49 forks source link

Clean Nth Catalan Number #127

Closed nilshah98 closed 5 years ago

nilshah98 commented 5 years ago

Do the checklist before filing the issue:

NOTE: Provide a clear and concise description of the feature that needs to be added! Or if its a bug, then provide the necessary steps to reproduce it along with screenshots.

Nth Catalan number has already been implemented here - #6 Check the corresponding PR, they've actually coded the binomialCoefficient part for calculating Catalan Number. Binomial Coefficient has been implemented here - #66

Aim here is to clean up the Catalan Number code, by using the nCr function already deployed.

Links-

6

66

Catalan GFG

pydevsg commented 5 years ago

I am interested to work on this issue @nilshah98 , but before assigning can you please explain what I need to resolve for solving this issue ,thanks.

nilshah98 commented 5 years ago

Check the code for Catalan Number, it uses nCr, but it is actually written as a whole. The task here is to reduce the redundancy and use the nCr function, instead of actually writing the whole function.

fave77 commented 5 years ago

@pydevsg will you be working on this?

pydevsg commented 5 years ago

Yes, I would like to grab this issue @pbiswas101.

fave77 commented 5 years ago

@pydevsg you're assigned!

nilshah98 commented 5 years ago

You need to make changes to the existing catalan number file, and not make a new one. src\catalan\index.js make changes to this.

pydevsg commented 5 years ago

Oh, sorry I took it in a different way , I will come up with a new PR .

nilshah98 commented 5 years ago

Cools!

fave77 commented 5 years ago

@pydevsg your time's up!

Shubhayu-Das commented 5 years ago

I would like to claim this issue.

fave77 commented 5 years ago

@sateslayer you're assigned