Closed Shubhayu-Das closed 5 years ago
Merging #149 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #149 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 78 77 -1
Lines 1273 1292 +19
=====================================
+ Hits 1273 1292 +19
Impacted Files | Coverage Δ | |
---|---|---|
src/convert/index.js | 100% <100%> (ø) |
|
src/index.js | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7ff791f...af99c34. Read the comment docs.
Ok, but if I do so, then it wouldn't be M.convert(...) anymore, would it? I will have to use the radian and degree modules which are there in the current version.
Why not? ...check the implementation of other modules like avg
, count
. I'm not even sure how is it working with your exports.convert
and convert = require('./convert')
, cause in your case it should have been convert = require('./convert').convert
Sorry, I figured it out. I'm using module.exports now. using exports.something is just a reference to module.exports = something. I guess that's why its working. In the test module, I was using M.convert. Now it's just convert(...).
I'll fix it by 7pm . Sorry about that 😅
I am closing this pull request and making a fresh one. Extremely sorry for the inconvenience.
Do the checklist before submitting the PR:
Q: What version of Node.js you've used in the project? (
e.g. Node v10.11.0
) A:v11.6.0 Q: Mention the Issue Number! (e.g. Fixed #8
) A:#140Give additional information regarding the PR below: Am adding convert module. Please verify the implementation. Also, I have removed the degree and radian modules.