fave77 / Mathball

A JavaScript library for Competitive Programming
https://fave77.github.io/Mathball-Docs/
MIT License
99 stars 49 forks source link

Adding convert module. Removing radian and degree.Issue #140 #153

Closed Shubhayu-Das closed 5 years ago

Shubhayu-Das commented 5 years ago

Do the checklist before submitting the PR:

Q: What version of Node.js you've used in the project? (e.g. Node v10.11.0) A:v11.6.3

Q: Mention the Issue Number! (e.g. Fixed #8) A:#140


codecov-io commented 5 years ago

Codecov Report

Merging #153 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #153   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          78     77    -1     
  Lines        1282   1301   +19     
=====================================
+ Hits         1282   1301   +19
Impacted Files Coverage Δ
src/convert/index.js 100% <100%> (ø)
src/index.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d8bd138...468a01a. Read the comment docs.

Shubhayu-Das commented 5 years ago

I'm having some issues with Istanbul. It's giving a "branch not visited color code, even though I have explicitly given the cases. Can anyone please take a look into it if possible?