fave77 / Mathball

A JavaScript library for Competitive Programming
https://fave77.github.io/Mathball-Docs/
MIT License
99 stars 49 forks source link

Added sort() function and transpose() in Matrix class #156

Closed sakshichahal53 closed 5 years ago

sakshichahal53 commented 5 years ago

Do the checklist before submitting the PR:

Q: What version of Node.js you've used in the project? (e.g. Node v10.11.0) A: v8.15.0

Q: Mention the Issue Number! (e.g. Fixed #8) A: Fixed #152

codecov-io commented 5 years ago

Codecov Report

Merging #156 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #156   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          77     78    +1     
  Lines        1301   1328   +27     
=====================================
+ Hits         1301   1328   +27
Impacted Files Coverage Δ
src/validation/matrix-sort-type.js 100% <100%> (ø)
src/Matrix/index.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6a44802...eabc410. Read the comment docs.

sakshichahal53 commented 5 years ago

Hi @pbiswas101, how to handle such conflicts/ erroneous reports in a PR. Should I close it every time such errors occur and create new PR or is it some way to handle it here only?

sakshichahal53 commented 5 years ago

@devRD I have used Code-Formatting in VSCode.

sakshichahal53 commented 5 years ago

@pbiswas101 Please check.

sakshichahal53 commented 5 years ago

I'll make a clean, new PR keeping in mind the suggested changes.