fave77 / Mathball

A JavaScript library for Competitive Programming
https://fave77.github.io/Mathball-Docs/
MIT License
99 stars 49 forks source link

Documentation: Count & Length #161

Closed fave77 closed 5 years ago

fave77 commented 5 years ago

Do the checklist before filing the issue:

NOTE: Provide a clear and concise description of the feature that needs to be added! Or if its a bug, then provide the necessary steps to reproduce it along with screenshots.

Provide brief documentation on both M.count() & M.length() inside the docs folder! A blank index.md is already provided for each module Required fields: a brief intro, Syntax, Arguments, Return, Examples, Info

For exact formatting, refer here!

NOTE: You're expected to provide elaborate examples which cover edge cases too.

devRD commented 5 years ago

can I work on this?

fave77 commented 5 years ago

@devRD you're assigned

devRD commented 5 years ago

@pbiswas101 Is count() supposed to return 0, when there are more than two arguments?

fave77 commented 5 years ago

@devRD, count() is supposed to throw an error, if there are more than 2 arguments and can you please rectify the implementation for this part?

devRD commented 5 years ago

Okay, I'll correct it. 🙂

devRD commented 5 years ago

@pbiswas101 Is the convert() function giving less coverage?

fave77 commented 5 years ago

@devRD yes it is!

devRD commented 5 years ago

@pbiswas101 Can I create a new issue on the coverage of count() and work on it?

fave77 commented 5 years ago

@devRD sure, but you meant convert, right!