Closed sakshichahal53 closed 5 years ago
Merging #169 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #169 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 78 78
Lines 1378 1406 +28
=====================================
+ Hits 1378 1406 +28
Impacted Files | Coverage Δ | |
---|---|---|
src/Matrix/index.js | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update dd4f552...769373f. Read the comment docs.
@sakshichahal53 @pbiswas101 Is an extra validation function necessary here? We can just use string validation and add a default case? I don't think the validation function that has been written is generalised, in what other module can it be used?
@sakshichahal53 @pbiswas101 Is an extra validation function necessary here? We can just use string validation and add a default case? I don't think the validation function that has been written is generalised, in what other module can it be used?
I agree on this one too
okay
Do the checklist before submitting the PR:
Q: What version of Node.js you've used in the project? (
e.g. Node v10.11.0
) A: v8.15.0Q: Mention the Issue Number! (
e.g. Fixed #8
) A: Fix #152