fave77 / Mathball

A JavaScript library for Competitive Programming
https://fave77.github.io/Mathball-Docs/
MIT License
99 stars 49 forks source link

Fix #152 matrix sort() added #169

Closed sakshichahal53 closed 5 years ago

sakshichahal53 commented 5 years ago

Do the checklist before submitting the PR:

Q: What version of Node.js you've used in the project? (e.g. Node v10.11.0) A: v8.15.0

Q: Mention the Issue Number! (e.g. Fixed #8) A: Fix #152

codecov-io commented 5 years ago

Codecov Report

Merging #169 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #169   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          78     78           
  Lines        1378   1406   +28     
=====================================
+ Hits         1378   1406   +28
Impacted Files Coverage Δ
src/Matrix/index.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dd4f552...769373f. Read the comment docs.

devRD commented 5 years ago

@sakshichahal53 @pbiswas101 Is an extra validation function necessary here? We can just use string validation and add a default case? I don't think the validation function that has been written is generalised, in what other module can it be used?

fave77 commented 5 years ago

@sakshichahal53 @pbiswas101 Is an extra validation function necessary here? We can just use string validation and add a default case? I don't think the validation function that has been written is generalised, in what other module can it be used?

I agree on this one too

sakshichahal53 commented 5 years ago

okay