Closed Brendonovich closed 5 years ago
Merging #215 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #215 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 80 80
Lines 1451 1463 +12
=====================================
+ Hits 1451 1463 +12
Impacted Files | Coverage Δ | |
---|---|---|
src/gcd/index.js | 100% <100%> (ø) |
:arrow_up: |
src/inverse/index.js | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f3cfa8a...b033470. Read the comment docs.
I am going to close this PR and squash my commits. I don't have much experience with git so I'm not confident with rebasing and the like.
Adds support for M.gcd() to evaluate the gcd of floating point numbers and numbers less than 0.
Do the checklist before submitting the PR:
Q: What version of Node.js you've used in the project? (
e.g. Node v10.11.0
) A: Node v10.15.3Q: Mention the Issue Number! (
e.g. Fixed #8
) A: Fixed #192Give additional information regarding the PR below: Implements feature requested in #192, and adds extra feature of finding positive gcd of negative numbers. Floating point numbers must not have more than 10 decimals (As decimals are iterated over in a for loop that executes a maximum of 10 times), and have more than a total of 16 digits (Number.MAX_INTEGER has 16 digits).