fave77 / Mathball

A JavaScript library for Competitive Programming
https://fave77.github.io/Mathball-Docs/
MIT License
99 stars 49 forks source link

Add floating point and negative support for GCD #215

Closed Brendonovich closed 5 years ago

Brendonovich commented 5 years ago

Adds support for M.gcd() to evaluate the gcd of floating point numbers and numbers less than 0.

Do the checklist before submitting the PR:

Q: What version of Node.js you've used in the project? (e.g. Node v10.11.0) A: Node v10.15.3

Q: Mention the Issue Number! (e.g. Fixed #8) A: Fixed #192

codecov-io commented 5 years ago

Codecov Report

Merging #215 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #215   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          80     80           
  Lines        1451   1463   +12     
=====================================
+ Hits         1451   1463   +12
Impacted Files Coverage Δ
src/gcd/index.js 100% <100%> (ø) :arrow_up:
src/inverse/index.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f3cfa8a...b033470. Read the comment docs.

Brendonovich commented 5 years ago

I am going to close this PR and squash my commits. I don't have much experience with git so I'm not confident with rebasing and the like.