Open fBruzja opened 4 years ago
Merging #218 into master will decrease coverage by
80.04%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #218 +/- ##
===========================================
- Coverage 100% 19.95% -80.05%
===========================================
Files 80 40 -40
Lines 1451 842 -609
===========================================
- Hits 1451 168 -1283
- Misses 0 674 +674
Impacted Files | Coverage Δ | |
---|---|---|
src/binary-search-tree/index.js | 5.47% <0%> (-94.53%) |
:arrow_down: |
src/validation/argument-length.js | 5.55% <0%> (-94.45%) |
:arrow_down: |
src/frugal/index.js | 7.69% <0%> (-92.31%) |
:arrow_down: |
src/divide/index.js | 9% <0%> (-91%) |
:arrow_down: |
src/validation/count.js | 9.09% <0%> (-90.91%) |
:arrow_down: |
src/validation/number-array.js | 11.11% <0%> (-88.89%) |
:arrow_down: |
src/validation/frequency.js | 11.11% <0%> (-88.89%) |
:arrow_down: |
src/Matrix/index.js | 11.49% <0%> (-88.51%) |
:arrow_down: |
src/prime/index.js | 12% <0%> (-88%) |
:arrow_down: |
src/bell/index.js | 13.33% <0%> (-86.67%) |
:arrow_down: |
... and 69 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f3cfa8a...4ed90a6. Read the comment docs.
Do the checklist before submitting the PR:
Q: What version of Node.js you've used in the project? (
e.g. Node v10.11.0
) A: v10.15.0Q: Mention the Issue Number! (
e.g. Fixed #8
) A: Fixed #192Give additional information regarding the PR below: 1) gcd function now supports floating point numbers 2) added another function that makes it possible for the result to round up to the maximum number of decimals the inputs had. 3) Added the relevant test case 4) Modified the documentation for the gcd function appropriately