fave77 / Mathball

A JavaScript library for Competitive Programming
https://fave77.github.io/Mathball-Docs/
MIT License
99 stars 49 forks source link

Radians to degree and vice versa #60

Closed ghost closed 5 years ago

ghost commented 5 years ago

Do the checklist before submitting the PR:

Q: What version of Node.js you've used in the project? (e.g. Node v10.11.0) A: v10.15.2

Q: Mention the Issue Number! (e.g. Fixed #8) A: Fixed #37


codecov-io commented 5 years ago

Codecov Report

Merging #60 into master will decrease coverage by 79.25%. The diff coverage is 16.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #60       +/-   ##
===========================================
- Coverage     100%   20.74%   -79.26%     
===========================================
  Files          40       15       -25     
  Lines         403      135      -268     
===========================================
- Hits          403       28      -375     
- Misses          0      107      +107
Impacted Files Coverage Δ
src/index.js 16.66% <16.66%> (-83.34%) :arrow_down:
src/validation/frequency.js 11.11% <0%> (-88.89%) :arrow_down:
src/bell/index.js 13.33% <0%> (-86.67%) :arrow_down:
src/validation/integer-array.js 14.28% <0%> (-85.72%) :arrow_down:
src/fibonacci/index.js 16.66% <0%> (-83.34%) :arrow_down:
src/prime/index.js 17.64% <0%> (-82.36%) :arrow_down:
src/catalan/index.js 20% <0%> (-80%) :arrow_down:
src/carmichael/index.js 20% <0%> (-80%) :arrow_down:
src/frequency/index.js 21.42% <0%> (-78.58%) :arrow_down:
src/factorial/index.js 22.22% <0%> (-77.78%) :arrow_down:
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 60545b0...b5dac59. Read the comment docs.

ghost commented 5 years ago

@bharati-s please go through the contribution guidelines and codebase so as how to contribute before making a PR. You needed to make two modules radian & degree

@pbiswas101 i have made the changes

ghost commented 5 years ago

@bharati-s do not delete the src/index.js, otherwise your PR won't be checked against Travis CI & Codecov properly! You also need to update the README.md. I'd suggest to first go through the existing codebase and understand how things are working and ask me if you have any doubt before making all these commits!

@pbiswas101 okay Sorry. Since its my first time working with github i'm not sure how this works. couldyou please elaborate what changes I've to make?