search

fave77 / Mathball

A JavaScript library for Competitive Programming
https://fave77.github.io/Mathball-Docs/
MIT License
99 stars 49 forks source link

nCr method and test cases implemented (#66). #81

Closed viditkumar closed 5 years ago

viditkumar commented 5 years ago

Do the checklist before submitting the PR:

Q: What version of Node.js you've used in the project? (e.g. Node v10.11.0) A: v8.11.4

Q: Mention the Issue Number! (e.g. Fixed #8) A: #66

codecov-io commented 5 years ago

Codecov Report

Merging #81 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #81   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          46     47    +1     
  Lines         516    532   +16     
=====================================
+ Hits          516    532   +16
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) :arrow_up:
src/nCr/index.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9d2be4a...e1f0ff9. Read the comment docs.

viditkumar commented 5 years ago

Created another pull request as per previous comment. Since this is the first time, I am making some contribution so I am facing a bit issue, gradually I will learn. Thanks.

nilshah98 commented 5 years ago

The code looks good to go. Good Job.