search

fave77 / Mathball

A JavaScript library for Competitive Programming
https://fave77.github.io/Mathball-Docs/
MIT License
99 stars 49 forks source link

String Permutation #92

Closed sweezy793 closed 5 years ago

sweezy793 commented 5 years ago

Do the checklist before submitting the PR:

Q: What version of Node.js you've used in the project? (e.g. Node v10.11.0) A:v10.15.1

Q: Mention the Issue Number! (e.g. Fixed #8) A: Fixed #84

codecov-io commented 5 years ago

Codecov Report

Merging #92 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #92   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          52     54    +2     
  Lines         620    645   +25     
=====================================
+ Hits          620    645   +25
Impacted Files Coverage Δ
src/validation/string.js 100% <100%> (ø)
src/index.js 100% <100%> (ø) :arrow_up:
src/permutation/index.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update adae2d3...d11ebe0. Read the comment docs.

sweezy793 commented 5 years ago

@pbiswas101 Please review the changes.

sweezy793 commented 5 years ago

@sweezy793 your PR shouldn't include changes to package-lock.json file

What about readme? It seems you changed it once. And the one where you requested changes doesn't have this function mentioned.

fave77 commented 5 years ago

@sweezy793 your readme.md had merge conflicts like it does now. That's why I had changed it.

sweezy793 commented 5 years ago

@sweezy793 your readme.md had merge conflicts like it does now. That's why I had changed it.

@pbiswas101 so now should I only change package-lock.json ?

fave77 commented 5 years ago

@sweezy793 your PR shouldn't include any modifications to package-lock.json!

sweezy793 commented 5 years ago

@sweezy793 your PR shouldn't include any modifications to package-lock.json!

Why did you close the PR? I was going to make changes

fave77 commented 5 years ago

@sweezy793 Make a PR from a different branch!