search

favish / atom-drupal

Drupal snippets, filetypes and hotkeys for the Atom Editor
MIT License
28 stars 14 forks source link

Adding snippets from drupal-sublimetext #3

Closed robballou closed 10 years ago

robballou commented 10 years ago

This is a rough pass at adding snippets from drupal-sublimetext. Since Atom does not currently support TM_FILENAME, some of the snippets may be broken from replacing that with just normal wildcards. This relates to issue #2.

michaelfavia commented 10 years ago

Thank you!. ill review this right now.

michaelfavia commented 10 years ago

I see no reason not to pull these in as they are better than not having them but they don't work on my atom. Reseraching cause now. You can confirm they work on atom .96?

I was tracking the .96 version of atom which now allows "Autocomplete now works when there are multiple selections." and another issue that allows multiple edit points for shared replacement points.

This means that snippets that implement the same token twice can have multiple insertion points if they use the same token.

robballou commented 10 years ago

I think the snippets work in .96, but are not always listed in autocomplete. I'm not sure why that happens. I know there's also an Atom snippet bug that will affect some of the snippets that use nested placeholders (like PHP's foreach snippet as an example). I still need to test the snippets/conversions a bit too ... but will update the fork if I find anything!

robballou commented 10 years ago

I added another update that came in via drupal-sublimetext, just a simple edit removing trailing semi-colons on a few snippets.