search

favonia / cloudflare-ddns

🌟 A small, feature-rich, and robust Cloudflare DDNS updater
Apache License 2.0
817 stars 36 forks source link

feat(cron): show the far start time during countdown #761

Closed favonia closed 3 months ago

favonia commented 3 months ago

Close #635.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.40%. Comparing base (38b5220) to head (be82bdf).

Files Patch % Lines
cmd/ddns/ddns.go 0.00% 2 Missing :warning:
internal/signal/signal.go 60.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #761 +/- ## ========================================== - Coverage 88.40% 88.40% -0.01% ========================================== Files 48 48 Lines 1992 2000 +8 ========================================== + Hits 1761 1768 +7 Misses 210 210 - Partials 21 22 +1 ``` | [Flag](https://app.codecov.io/gh/favonia/cloudflare-ddns/pull/761/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=favonia) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/favonia/cloudflare-ddns/pull/761/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=favonia) | `88.40% <76.47%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=favonia#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

favonia commented 3 months ago

@chrede88 Hi, this PR attempts to implement something like this:

... in about 19m0s (3:46PM) . . .

but only when the countdown is at least 10 minutes. I wonder if this is enough? I might be merging this PR without waiting for you, but please feel free to chime in at any point of time.

chrede88 commented 3 months ago

@chrede88 Hi, this PR attempts to implement something like this:

... in about 19m0s (3:46PM) . . .

but only when the countdown is at least 10 minutes. I wonder if this is enough? I might be merging this PR without waiting for you, but please feel free to chime in at any point of time.

Sounds great! Thank you for your great work :+1: