search

favonia / cloudflare-ddns

🌟 A small, feature-rich, and robust Cloudflare DDNS updater
Apache License 2.0
662 stars 25 forks source link

fix(monitor): distinguish success pinging from logging in SendResponse #769

Closed favonia closed 1 month ago

favonia commented 1 month ago

The bug was introduced in #762.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.91%. Comparing base (9cdfec3) to head (55c51e2).

Files Patch % Lines
cmd/ddns/ddns.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #769 +/- ## ========================================== + Coverage 90.90% 90.91% +0.01% ========================================== Files 52 52 Lines 2122 2125 +3 ========================================== + Hits 1929 1932 +3 Misses 182 182 Partials 11 11 ``` | [Flag](https://app.codecov.io/gh/favonia/cloudflare-ddns/pull/769/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=favonia) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/favonia/cloudflare-ddns/pull/769/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=favonia) | `90.91% <80.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=favonia#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.