favonia / cloudflare-ddns

🌟 A small, feature-rich, and robust Cloudflare DDNS updater
Apache License 2.0
879 stars 39 forks source link

refactor: remove unnecessary indirection #815

Closed favonia closed 3 months ago

favonia commented 3 months ago

It's also faster to pass structures directly except for really large ones.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 98.48485% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.94%. Comparing base (33181a5) to head (70175cd).

Files Patch % Lines
cmd/ddns/ddns.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #815 +/- ## ========================================== + Coverage 93.93% 93.94% +0.01% ========================================== Files 53 53 Lines 2177 2181 +4 ========================================== + Hits 2045 2049 +4 Misses 120 120 Partials 12 12 ``` | [Flag](https://app.codecov.io/gh/favonia/cloudflare-ddns/pull/815/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=favonia) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/favonia/cloudflare-ddns/pull/815/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=favonia) | `93.94% <98.48%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=favonia#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.