favonia / cloudflare-ddns

🌟 A small, feature-rich, and robust Cloudflare DDNS updater
Apache License 2.0
879 stars 39 forks source link

fix(api): decouple account IDs from operations on DNS records #875

Closed favonia closed 2 months ago

favonia commented 2 months ago

This will completely prevent #691 from happening again!

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.76%. Comparing base (7d4e834) to head (e356784).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #875 +/- ## ========================================== - Coverage 94.76% 94.76% -0.01% ========================================== Files 58 58 Lines 2618 2616 -2 ========================================== - Hits 2481 2479 -2 Misses 125 125 Partials 12 12 ``` | [Flag](https://app.codecov.io/gh/favonia/cloudflare-ddns/pull/875/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=favonia) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/favonia/cloudflare-ddns/pull/875/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=favonia) | `94.76% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=favonia#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.