favoretti / terraform-provider-adx

Mozilla Public License 2.0
14 stars 5 forks source link

Add concurrency and maxSourceRecordsForSingleIngest as optional params to MVs #42

Closed FakieHeelflip closed 1 year ago

FakieHeelflip commented 1 year ago

Ref: https://learn.microsoft.com/en-us/azure/data-explorer/kusto/management/materialized-views/materialized-view-create#backfill-a-materialized-view

These parameters can be useful in cases where backfill=true.

Hopefully I did everything correct. Feel free to edit so I can learn. Thank you.

slwbuild commented 1 year ago

Left a few comments about a tiny issue which only applies during view update.

Do you mind also augmenting the acceptance tests to include these options?

FakieHeelflip commented 1 year ago

I gave it a try.

slwbuild commented 1 year ago

Looks like a good try to me. All tests pass. Thanks!