Closed GoogleCodeExporter closed 9 years ago
can you please use svn diff?
Thanks,
Erwin
Original comment by erwin.coumans
on 13 Sep 2011 at 4:35
1) btBoxShape against btBoxShape is a special case, and it will generate
multiple contacts. So it is likely that btStaticPlaneShape is not the special
case.
2) It will help if you modify an existing demo, without requiring any other
modifications (similar with the quaternion patch, don't bundle multiple changes
in a single patch)
3) always use Subversion's svn diff command to create a patch
Thanks a lot,
Erwin
Original comment by erwin.coumans
on 13 Sep 2011 at 7:31
I guess I consider this contribution the basis for a unit test system than a
single bug report. I'll see about making a one-off for the box/plane thing
though. But if you like this I can clean it up to make it easy for you or
others to jump in and add new test cases. My rationale is that the existing
demos are great for playing and interactive experiments, but they don't really
allow automated testing/quantification of regressions. (So maybe this should
be filed under 'Extras' instead of 'Demos', I dunno, give feedback if you're
interested in any of this.)
FYI, the trick with doing diffs with SVN (3) is that it conflicts with (2)...
either I get all my local changes (e.g. all of the bugs I've filed recently) or
I select on file/directory basis, which still isn't going to give separation of
unrelated patches when they touch the same file, and doesn't ensure I remember
to include all of the relevant files and none of the irrelevant ones... DVCS
makes this much easier/robust ;)
I guess I could apply each of my patches to a clean svn checkout and then
regenerate a patch from there with svn... but this is kind of roundabout. So
for my reference, is there something special about svn's diffs vs. the ones
from hg? Maybe there's an easier way to give you what you're looking for?
Original comment by ejtt...@gmail.com
on 13 Sep 2011 at 8:29
svn diff'd version of the patches...
Original comment by ejtt...@gmail.com
on 13 Sep 2011 at 8:40
Attachments:
Let's merge the issue with the newer one
THanks for the repro cases!
Original comment by erwin.coumans
on 13 Sep 2011 at 11:41
Umm, well they're not really the same thing. This is a tool for running a set
of test cases over a set of simulation parameters. In particular, the third
test case regards constraints 'breaking' between relatively small objects which
is otherwise still unaddressed.
I could make a version of BasicDemo for that too, but I'd still appreciate it
if you took this for a spin as well...
Original comment by ejtt...@gmail.com
on 14 Sep 2011 at 12:29
Thanks!
I'll give it a try, but if you can create a BasicDemo version that would be
appreciated as well.
Original comment by erwin.coumans
on 14 Sep 2011 at 2:02
Original issue reported on code.google.com by
ejtt...@gmail.com
on 13 Sep 2011 at 4:22Attachments: