search

favreau / bullet

Automatically exported from code.google.com/p/bullet
0 stars 0 forks source link

Potential Bug in resolveSplitPenetrationSIMD #566

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
In line 228 of btSequentialImpulseConstraintSolver.cpp, method 
resolveSplitPenetrationSIMD

c.m_appliedImpulse = _mm_or_ps( _mm_and_ps(resultLowerLess, lowerLimit1), 
_mm_andnot_ps(resultLowerLess, sum) );

Should that not be

c.m_appliedPushImpulse = _mm_or_ps( _mm_and_ps(resultLowerLess, lowerLimit1), 
_mm_andnot_ps(resultLowerLess, sum) );

This is what the non-simd version does and I get a results mismatch when 
enabling SIMD.

Original issue reported on code.google.com by peter.kyme on 10 Nov 2011 at 8:14

GoogleCodeExporter commented 9 years ago 

Did you check the latest SVN trunk?

It should be fixed in this commit:
http://code.google.com/p/bullet/source/detail?r=2442

Thanks for the report anyhow,
Erwin

Original comment by erwin.coumans on 11 Nov 2011 at 12:51

GoogleCodeExporter commented 9 years ago 
Ah, so it is, my mistake. I only checked against 2.79.

Original comment by peter.kyme on 11 Nov 2011 at 11:09

GoogleCodeExporter commented 9 years ago

Original comment by erwin.coumans on 11 Nov 2011 at 4:26