feat: Handle Directory Imports, Node Builtins

favware / esbuild-plugin-file-path-extensions

An esbuild plugin to automatically insert file extensions in your built JavaScript files based on the specified target

MIT License

18 stars 1 forks source link

feat: Handle Directory Imports, Node Builtins #104

Closed beeequeue closed 3 months ago

beeequeue commented 4 months ago

This PR adds support for handling:

Directory imports (import x from "./directory" where the file is ./directory/index.js)
Node builtins (import path from "path")

I first added tests to verify that these cases would be handled incorrectly, after which I fixed them 😄

Not sure if this is a feat or a fix

At least partially fixes #6

beeequeue commented 4 months ago

I found that most snapshots have that error, so I updated those as well.

I couldn't see why it wasn't using esbuild's format option as the default so I added that to fix said snapshots.

I still have no idea why the last snapshot is failing, even after going stepby-step in the debugger...

favna commented 3 months ago

I'll be honest I didn't realise you work for Paypal until I merged the PR and I saw your email in the commit body. That's pretty damn cool that my project is used at Paypal. That's pretty big for a simple open-source contributor like me. Thanks!!

favna commented 3 months ago

Released in v2.1.0, not sure why GitHub doesn't detect it automatically.