search

favware / graphql-pokemon

Extensive Pokémon GraphQL API
http://graphql-pokemon.js.org/
MIT License
150 stars 13 forks source link

request: high res images #825

Open EvolutionX-10 opened 1 year ago

EvolutionX-10 commented 1 year ago

Is there an existing issue or pull request for this?

Feature description

High resolution images of pokemon would be a neat addition

Desired solution

redirection links to serebii images

Alternatives considered

none

Additional context

No response

favna commented 1 year ago

Work started in the feat/highres-sprites branch but I'm not sure how to tackle the high-res sprites. Serebii is just too darn inconsistent in their URLs For example the three forms of Tauros Paldean: https://www.serebii.net/scarletviolet/pokemon/new/128-p.png https://www.serebii.net/scarletviolet/pokemon/new/128-b.png https://www.serebii.net/scarletviolet/pokemon/new/128-a.png

Sure the top one could be parsed from paldea as form. Still, the other two are actually called Paldean-Fire and Paldean-Water except Serebii insists on using battle and aqua, their alternative non-parseable form names. Smogon uses the fire and water additions because it makes sense and is easily parseable and distinguishable especially because the -a postfix is also used for Alolan forms.

And on top of that, I also cannot find a solid list of Pokemon that are not transferrable from Gen 7 to Gen 8 through Pokemon Home. This becomes a problem with something like Alolan Rattata which is only available in Gen 7, whereas Alolan Marowak is available in Gen 8. So I cannot simply look at the form and say "oh yes pick that URL" either.

So I'm honestly stuck. I don't know how I can reliably get the proper URLs clearly not through Serebii.

favna commented 1 year ago

We can leverage https://github.com/HybridShivam/Pokemon/ for this, however, it does not yet have generation 9 assets. Those will be added later. Tracking that in https://github.com/HybridShivam/Pokemon/issues/11