search

favware / rollup-type-bundler

A small CLI tool to bundle types with rollup
MIT License
12 stars 2 forks source link

bug: TypeError: Cannot read properties of undefined (reading 'concat') #123

Closed lolollllo closed 2 years ago

lolollllo commented 2 years ago

Describe the bug Undefined term 'concat' in package src

To Reproduce

  1. Execute 'rollup-type-bundler -e stream'
  2. See error

Expected behavior Not to throw an error

The package gets to be published without the error being thrown

Screenshots

image

FULL ERROR

    .option('-e, --external [external...]', `Repeatable, each will be treated as a new entry. Library or libraries to treat as external in Rollup (see: ${cyan('https://rollupjs.org/guide/en/#warning-treating-module-as-external-dependency')})`, (value, previous) => previous.concat([value]));
                                                                                                                                                                                                                                                                                  ^
TypeError: Cannot read properties of undefined (reading 'concat')
    at Option.parseArg (file:///home/runner/work/discord-portable-player/discord-portable-player/node_modules/@favware/rollup-type-bundler/dist/cli.js:23:275)
    at handleOptionValue (/home/runner/work/discord-portable-player/discord-portable-player/node_modules/@favware/rollup-type-bundler/node_modules/commander/lib/command.js:539:24)
    at Command.<anonymous> (/home/runner/work/discord-portable-player/discord-portable-player/node_modules/@favware/rollup-type-bundler/node_modules/commander/lib/command.js:566:7)
    at Command.emit (node:events:5[37](https://github.com/lolollllo/discord-portable-player/runs/7051610617?check_suite_focus=true#step:5:38):28)
    at Command.parseOptions (/home/runner/work/discord-portable-player/discord-portable-player/node_modules/@favware/rollup-type-bundler/node_modules/commander/lib/command.js:1[41](https://github.com/lolollllo/discord-portable-player/runs/7051610617?check_suite_focus=true#step:5:42)7:18)
    at Command._parseCommand (/home/runner/work/discord-portable-player/discord-portable-player/node_modules/@favware/rollup-type-bundler/node_modules/commander/lib/command.js:1196:25)
    at Command.parse (/home/runner/work/discord-portable-player/discord-portable-player/node_modules/@favware/rollup-type-bundler/node_modules/commander/lib/command.js:891:10)
    at file:///home/runner/work/discord-portable-player/discord-portable-player/node_modules/@favware/rollup-type-bundler/dist/cli.js:24:25
favna commented 2 years ago

Ah... That's an oversight caused by a recent change. Crud. I'll get around fixing this tomorrow I think.

lolollllo commented 2 years ago

Ah... That's an oversight caused by a recent change. Crud. I'll get around fixing this tomorrow I think.

Alright.

favna commented 2 years ago

Fix released in v1.0.9