search

fawaz-ahmed / react-native-read-more

React native library to show text in a condensed way and expand when needed. Drop in replacement for Text component and highly customizable. Can be used with expo or native cli for react native.
https://www.npmjs.com/package/@fawazahmed/react-native-read-more
MIT License
274 stars 37 forks source link

are you using TextPropTypes? because it's deprecated by React Native #74

Closed hotaryuzaki closed 1 year ago

hotaryuzaki commented 1 year ago

it is a question, are you using TextPropTypes? it's deprecated by React Native and will rise an error Invariant Violation: ViewPropTypes has been removed from React Native. Migrate to ViewPropTypes exported from 'deprecated-react-native-prop-types'

fawaz-ahmed commented 1 year ago

I will check this one. Thanks for raising this issue.

fawaz-ahmed commented 1 year ago

@hotaryuzaki I tested with both js and ts. I didn't saw any violations. Although TextPropTypes is being used. Can you help me reproduce this issue ? or provide a way of reproducing this warning.

hotaryuzaki commented 1 year ago

@hotaryuzaki I tested with both js and ts. I didn't saw any violations. Although TextPropTypes is being used. Can you help me reproduce this issue ? or provide a way of reproducing this warning.

what RN version are you using? try using RN 0.70.5

fawaz-ahmed commented 1 year ago

@hotaryuzaki tried with rn version 0.70.5 and 0.70.6. It worked fine. But in any case I will remove ref for TextPropTypes since it's deprecated