fawazahmed0 / exchange-api

Free Currency Exchange Rates API with 200+ Currencies & No Rate Limits
https://github.com/fawazahmed0/exchange-api#readme
Creative Commons Zero v1.0 Universal
720 stars 46 forks source link

Add timestamp for latest api #21

Closed xixixao closed 3 years ago

xixixao commented 3 years ago

Incredibly amazing project, thank you. The situation around forex rate apis is frankly ridiculous. You built exactly what I imagined should exist. Kudos.

I'd mention that bing and google are the sources and that the data updates daily in the readme (just to make it obvious).

No it's possible that this system will break in the future for some reason. Could you add a way to find out when is the latest data from? I could then do something like if latest.date - now > 50 days { show warning to user }.

Thanks again!

fawazahmed0 commented 3 years ago

Incredibly amazing project, thank you. The situation around forex rate apis is frankly ridiculous. You built exactly what I imagined should exist. Kudos.

Thanks @xixixao

I'd mention that bing and google are the sources

Well, the reason I haven't mentioned about them is that, the program scrapes the data from these sources, and it might not be legal There is a possibility that the data providers such as morningstar, coinbase or Refinitiv, may file DMCA takedown and this whole repo could go down. So I felt better not to mention about the sources.

Screenshot (114) Screenshot (113)

that the data updates daily in the readme (just to make it obvious).

I did mention that the rates are updated daily. You might have missed it: Screenshot (112)

No it's possible that this system will break in the future for some reason.

It did break few times(2 times in last 6 months), and I do receive email when the CI workflow fails. As I use this API in my other projects, I fix it on the same day itself.

Thanks

fawazahmed0 commented 3 years ago

Ok I have added the date https://cdn.jsdelivr.net/gh/fawazahmed0/currency-api@1/latest/currencies/usd/jpy.json

It usually takes sometime for the jsdelivr to pickup the new data

xixixao commented 3 years ago

You're probably aware that ECB also publishes rates, it might be a good fallback if the other sources become unavailable. (but we'll see when we hit that wall)

fawazahmed0 commented 9 months ago

currency-api has stopped working, Please read the migration guide