fawazahmed0 / exchange-api

Free Currency Exchange Rates API with 200+ Currencies & No Rate Limits
https://github.com/fawazahmed0/exchange-api#readme
Creative Commons Zero v1.0 Universal
729 stars 46 forks source link

Better usable JSON format #23

Closed SofiyanIfren closed 3 years ago

SofiyanIfren commented 3 years ago

Hi, I use your very nice API for a Discord.js bot, it is very simple to use, even if it would be prettier if the JSON format of the conversion URL (https://cdn.jsdelivr.net/gh/fawazahmed0/currency-api@1/latest/currencies/eur/jpy.json for example) response looked like : { "date": "2021-06-22", "change": { "currency " : "jpy", "amount" : "131.418702"} } I think it would be more useful; if you want this from me, I can contribute by sending you a PR Thank you for your work !

fawazahmed0 commented 3 years ago

Recently someone requested me to add date/timestamp in json. After adding that, my api broke for one person, due to date option, see this.

So I cannot add anything new or remove anything from the JSON( or change the format of JSON), otherwise it will break for old users, I hope you understand that.

Thank you for considering this 👍

SofiyanIfren commented 3 years ago

Ok I understand, thank you for your work !

Le mer. 23 juin 2021 à 12:36, Fawaz Ahmed @.***> a écrit :

Recently someone requested me https://github.com/fawazahmed0/exchange-api/issues/21 to add date/timestamp in json. After adding that, my api broke for one person, due to date option, see this https://github.com/fawazahmed0/exchange-api/issues/22.

So I will not add anything new or remove anything from the JSON( or change the format of JSON), otherwise it will break for old users, I hope you understand that.

Thank you for considering this 👍

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fawazahmed0/exchange-api/issues/23, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHQIFU4SZECZPCLRPMBPVGDTUG2L5ANCNFSM47FKIDZQ .

fawazahmed0 commented 9 months ago

currency-api has stopped working, Please read the migration guide