search

fawazahmed0 / hadith-api

Free Hadith API Service with Multiple Languages and Multiple Grades
The Unlicense
211 stars 46 forks source link

Some Hadith are missing #23

Open GibreelAbdullah opened 1 year ago

GibreelAbdullah commented 1 year ago

For eg - Bukhari 4434 is missing in linebyline folder.

Also missing in API - https://cdn.jsdelivr.net/gh/fawazahmed0/hadith-api@1/editions/eng-bukhari/4434.min.json

But Sunnah.com has it - https://sunnah.com/bukhari:4434

There are multiple such issues

GibreelAbdullah commented 1 year ago

Adding few more examples -

https://sunnah.com/muslim:637 https://cdn.jsdelivr.net/gh/fawazahmed0/hadith-api@1/editions/eng-muslim/637.min.json

https://sunnah.com/muslim:852 https://cdn.jsdelivr.net/gh/fawazahmed0/hadith-api@1/editions/eng-muslim/852.min.json

unkn4wn commented 1 year ago

Adding few more examples -

https://sunnah.com/muslim:637 https://cdn.jsdelivr.net/gh/fawazahmed0/hadith-api@1/editions/eng-muslim/637.min.json

https://sunnah.com/muslim:852 https://cdn.jsdelivr.net/gh/fawazahmed0/hadith-api@1/editions/eng-muslim/852.min.json

Be careful. This isnt the same hadith. The hadithnumber in the Hadith api Sahih Muslim is completely different than the hadithnumber in sunnah.com You need to look at "arabicnumber" in the api

unkn4wn commented 1 year ago

For eg - Bukhari 4434 is missing in linebyline folder.

Also missing in API - https://cdn.jsdelivr.net/gh/fawazahmed0/hadith-api@1/editions/eng-bukhari/4434.min.json

But Sunnah.com has it - https://sunnah.com/bukhari:4434

There are multiple such issues

And this hadith isn't really missing. The Api shows this hadith as hadith number 4433 while sunnah.com shows this hadith as 4433,4434. Check these both links: https://cdn.jsdelivr.net/gh/fawazahmed0/hadith-api@1/editions/eng-bukhari/4433.min.json https://sunnah.com/bukhari:4434

Only 4433 is mentioned in this api because there's no way to mention two numbers as "hadithnumber" except we are converting "hadithnumber" to a string. But idk if this would break sites/apps which are using this api right now.

GibreelAbdullah commented 1 year ago

Jazakallahu Khairan

Could have duplicate for both 4433 and 4434 instead of giving blank for one.

GibreelAbdullah commented 1 year ago

Found more such Ahadith, but this issue is a bit different. In Sunnah.com these two numbers have 2 hadiths associated with them.

https://cdn.jsdelivr.net/gh/fawazahmed0/hadith-api@1/editions/eng-tirmidhi/1424.min.json https://cdn.jsdelivr.net/gh/fawazahmed0/hadith-api@1/editions/eng-tirmidhi/1425.min.json

https://sunnah.com/tirmidhi/17

GibreelAbdullah commented 1 year ago

Are there any plans for it brother @fawazahmed0.

I am thinking of creating a script to copy the data of

https://cdn.jsdelivr.net/gh/fawazahmed0/hadith-api@1/editions/eng-bukhari/4433.min.json to https://cdn.jsdelivr.net/gh/fawazahmed0/hadith-api@1/editions/eng-bukhari/4434.min.json

and similarly for all such cases.

fawazahmed0 commented 1 year ago

I am thinking of creating a script to copy the data

If you could submit a PR, that will be very helpful

GibreelAbdullah commented 1 year ago

InShaAllah, will work on it. Am traveling this weekend, by next weekend only I will be free.